Fix search #198
Closed
Fix search #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
reviewed
Nov 10, 2017
app/public/js/app.js
Outdated
| updater: function (item) { | ||
| // get text to display in quick search box | ||
| var displayText = item; | ||
| console.log(item); |
Member
There was a problem hiding this comment.
probably want to remove the console.log
Collaborator
Author
There was a problem hiding this comment.
You are right, I removed it in a163bae and forgot to also do so here.
But keep in mind that this function doesn't exist any more with the full text search in #200 as I am using a maintained fork of twitter bootstrap there, because it's more user friendly (results can be selected with the arrow keys)
Collaborator
Author
|
Closing in favor of #330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
It got a bit more than just one change as the old typeahead version didn't support the "all" parameter and the new one works a bit different.
But altogether the search now works as it should and the json file is loaded only once on focus of the search box.